Foreach (Or bolding going where i've never gone)

So I'm making a framework for Ars Magica that has a slightly odd mechanic in it: Botch dice.

What i need to do is roll Xd10, and count the number of 0's (or 10s as the case may be). What i have so far is:

Code:

[foreach(i,BotchDice,"<br>"),Code:
{
[t:BotchRoll=d10]
}
]

After a simple input for the number of dice to be rolled, however it's only ever rolling 1d10, no matter what the number of BotchDice is.

aku wrote:

So I'm making a framework for Ars Magica that has a slightly odd mechanic in it: Botch dice.

What i need to do is roll Xd10, and count the number of 0's (or 10s as the case may be). What i have so far is:

Code:

[foreach(i,BotchDice,"<br>"),Code:
{
[t:BotchRoll=d10]
}
]

After a simple input for the number of dice to be rolled, however it's only ever rolling 1d10, no matter what the number of BotchDice is.

foreach iterates over an array of things, if you are prompted for BotchDice, then it's a simple string. You should likely be using COUNT instead.... Also, I would highly suggest assigning to a temp variable and passing that as your "max" variable instead of relying on the input "results".

You might be interested in my Ars Magica framework (5th edition) - at least to look what i've done. I prepared it for another setting, so I did not code any magic stuff into it.

You can find it here.

EDIT: forgot to say... feel free to rip it apart and use every part you find useful.

What you want to do doesn't really require foreach:

Code:

[h: rollList = ""]
[h, for(i,0,noOfRolls), code :{
[h: rollList = listAppend(rollList,roll(1,10))]
}]
[h: noOfZeros = listCount(rollList)]
[h: output(noOfZeros)] 

As an alternative using [for:].

Bone White wrote:

What you want to do doesn't really require foreach:

Code:

[h: rollList = ""]
[h, for(i,0,noOfRolls), code :{
[h: rollList = listAppend(rollList,roll(1,10))]
}]
[h: noOfZeros = listCount(rollList)]
[h: output(noOfZeros)] 

As an alternative using [for:].

that aint gonna work. The result will be always noOfRolls.
I think you meant:

Code:

[h: rollList = ""]
[h, count(noOfRolls):rollList = listAppend(rollList,roll(1,10))]
[h: noOfZeros = listContains(rollList, 0)]
Number of zeros rolled: {noOfZeros}
  

If all you care about is the botch count, then you can use the XdYsT dice expression:

Code:

[H: abort(input("numDice|1|How many Botch Dice?|TEXT"))]
[R, if(isNumber(numDice)): strformat("Botch Dice Rolled: %{numDice}<br>Number of Botches: %s",eval(numDice+"d10s10")); 
   "You must enter a valid number."] 

wolph42 wrote:

Bone White wrote:

What you want to do doesn't really require foreach:

Code:

[h: rollList = ""]
[h, for(i,0,noOfRolls), code :{
[h: rollList = listAppend(rollList,roll(1,10))]
}]
[h: noOfZeros = listCount(rollList)]
[h: output(noOfZeros)] 

As an alternative using [for:].

that aint gonna work. The result will be always noOfRolls.
I think you meant:

Code:

[h: rollList = ""]
[h, count(noOfRolls):rollList = listAppend(rollList,roll(1,10))]
[h: noOfZeros = listContains(rollList, 0)]
Number of zeros rolled: {noOfZeros}
  

Actually, this wouldn't work either. You would either have to change the roll (1-10 to 0-9) or what you're checking for in the list (change 0 to 10).

Even the simplest of macros can throw us, which is why extensive testing is required!

Don't lose heart though, I love learning, and should learn to test code I post to make sure it's correct...

aliasmask wrote:

wolph42 wrote:

Bone White wrote:

What you want to do doesn't really require foreach:

Code:

[h: rollList = ""]
[h, for(i,0,noOfRolls), code :{
[h: rollList = listAppend(rollList,roll(1,10))]
}]
[h: noOfZeros = listCount(rollList)]
[h: output(noOfZeros)] 

As an alternative using [for:].

that aint gonna work. The result will be always noOfRolls.
I think you meant:

Code:

[h: rollList = ""]
[h, count(noOfRolls):rollList = listAppend(rollList,roll(1,10))]
[h: noOfZeros = listContains(rollList, 0)]
Number of zeros rolled: {noOfZeros}
  

Actually, this wouldn't work either. You would either have to change the roll (1-10 to 0-9) or what you're checking for in the list (change 0 to 10).

Bone White wrote:

Even the simplest of macros can throw us, which is why extensive testing is required!

Don't lose heart though, I love learning, and should learn to test code I post to make sure it's correct...

Lol!! Well at least we've reinforced the current hiarchy of coding skills

Well, if it wasn't for my mistakes, you two couldn't shine (and out-shine) each other, so if it wasn't for me you wouldn't look as good

Bone White wrote:

Well, if it wasn't for my mistakes, you two couldn't shine (and out-shine) each other, so if it wasn't for me you wouldn't look as good

which is why we have this code skill hiarchy... to make me look good

my oh my, where as this thread gone over the course of a few days. So, count mostly works, although, i'm thinking of packaging the numbers i get into an array, and passing that through a for each, to generate a simple, "you botch with X dice" or "You dont botch"...

aku wrote:

my oh my, where as this thread gone over the course of a few days. So, count mostly works, although, i'm thinking of packaging the numbers i get into an array, and passing that through a for each, to generate a simple, "you botch with X dice" or "You dont botch"...

Don't forget to take a look at this solution.

RPTools.net

Foreach (Or bolding going where i've never gone)

Who is online

Top

Top

Top

Top