Mass Rolling Macro (Help Needed)

[aliasmask]

I thought Raktus wanted the input to pop up only once and apply the same settings for every token, doesn't that code make it appear for every token selected?

My input only shows up once outside of the loop. What may be happening in your testing is you have the macro set to "Apply to all tokens" which you don't want to do. That will essentially run it on each token, then loop through all the tokens making it run X squared times where X is the number of tokens selected.

[Irrlicht]

Ah, alright, I hadn't tested it, but yes, I was mentally applying to selected tokens for habit.

[aliasmask]

Ah, alright, I hadn't tested it, but yes, I was mentally applying to selected tokens for habit.

Something to note on that part though, if you do it my way anyone can run the macro on any tokens, even unowned tokens. More code will be needed if you want to limit the selected tokens to owned tokens, which is pretty easy. But in a friendly game, that probably isn't a high priority.

[wolph42]

edit: missed the fact that there was an entire page of discussion on teh next page, but ill leave this post anyway here.

I would do it slightly more efficient and more 'resilient':

Code: Select all

[H: selected = getSelectedNames("json")]
[h:assert(listCount(selected),"Make sure at least one token is selected",0)]

<!-- Set a variable outside of the foreach -->
[H:abort(input("attribute|Strength,Dexterity,Constitution|Select Attribute|LIST|VALUE=STRING"))]

[H: output = "[]"]
[H, foreach(tokenName,selected), if(isOwner(getPlayerName(), tokenName)), code: {
   [roll                = 1d20]
   [attributeBonus    = floor((number(getProperty(attribute, tokenName))-10)/2)]
   [result            = roll + attributeBonus]
   [output            = json.append(output,strformat("%{tokenName}: %{roll} + %{attributeBonus} = %{result}"))]
}]

[R: json.toList(output,"<br>")]