setGM/Notes() getGM/Notes() tokenID parameter

[celestian]

So I was planning to use the GM notes section to "log" certain things for tokens but it seems you have to "select" the token you want to do this with... while I can do that I'd like to request a parameter on the function like the other get/set() functions (tokenID).

I want to create a "logit()" function and then use it in various macros (on various tokens).

Yes I can get the existing "Selected" then force select of the token I want to log to...in the UDF but, it just would be a lot simpler and cause less issues down the road, if we had a "tokenID" parameter in the set/get notes functions.

[wolph42]

first part: im not following you, are you talking about Wiki: switchToken() ?

and yes it would be easier if there was an optional parameter for get/setNotes to set tokID. But for now we have switchToken.

[RPTroll]

Added as task 15.8 to https://docs.google.com/spreadsheets/d/ ... sp=sharing
15.8 Add tokenId to get/set GmNotes Macros Open http://forums.rptools.net/viewtopic.php?f=26&t=25887

[aliasmask]

You can also do this:

[H, token(tokenId): setNotes("blah")]

[celestian]

You can also do this:

[H, token(tokenId): setNotes("blah")]

Oh, that works. I only have one question. Is there a way to do something like this?

Code: Select all

[previous = token("Lib:Log"): getGMNotes()]

I tried the above and it didn't seem to like it. What I am hoping to do is get the "previous" entries and then

Code: Select all

[H, token("Lib:Log"): setGMNotes(previous+" "+macro.args)]

[aliasmask]

Well, it kind of depends. Obviously, GM notes are only accessible by the GM, so it needs to be a trusted macro and probably needs to be on the lib token. Another problem is that lib token will need to be on the current map. So, your example should work given those 2 factors.

I would probably use variables on the lib token to hold that info, but have a mouseover event write from the variable to the gm notes if that's where you want it.

ie

*writeGMNotes(never displayed): [H: udf.writeGMNotes()]

But that seems awkward to me. I use my own GM note system for running modules.

[JamzTheMan]

Did you try this? (untested but makes sense to me...)

Code: Select all

[token("Lib:Log"): previous = getGMNotes()]

[celestian]

Did you try this? (untested but makes sense to me...)

Code: Select all

[token("Lib:Log"): previous = getGMNotes()]

Hah! Works. Thanks

That's a funny little trick, great to know!

[Jagged]

Code for setGM/Notes() getGM/Notes() submitted for 1.4

[JamzTheMan]

since the those functions existed, I assume you just added the id param?

[Jagged]

You've got me worried now, I am going to have to double check!

Notes had a separate class rather than sit in TokenProperties, so I moved the functions to TokenProperties, but forgot to clean up the redundant code

[JamzTheMan]

You've got me worried now, I am going to have to double check!

Notes had a separate class rather than sit in TokenProperties, so I moved the functions to TokenProperties, but forgot to clean up the redundant code

src\main\java\net\rptools\maptool\client\functions\TokenNoteFunctions.java?

[Jagged]

Yes.

If there is some reason why people would prefer to have a separate class for this rather than have it sit with the other token properties, I am happy to reconfigure it.

[JamzTheMan]

ah ok, sorry, misread the post. Did you add the id as a parameter as well?

[Jagged]

Yes.