b90 breaking some macros

[Barlie]

I'm not entirely sure where this thread should go, but since the macro worked before, I figure it might be better treated as a bug than macro help.

I downloaded and installed the b90 beta build. For some reason, the initiative macros I got working in b89 do not work in the b90 build. Here's my macro for npc initiative:

Code: Select all

[h: i = getInitiativeRound()]
[h: removeAllFromInitiative()]
[h, if (i >0): setInitiativeRound(i+1); setInitiativeRound(1)]

[h, code:{
[jsonNPC = getNPC("json")]
[jsonInit = '[]']
}]

[h, foreach(id, jsonNPC), code:{
[jsonInsert = json.set('{}', "id", id, "init", d10)]
[jsonInit = json.append(jsonInit, jsonInsert)]
}]

[h: jsonInit = json.sort(jsonInit, "ascending", "init")]

[h, foreach(item, jsonInit), code:{
[current = json.get(item, "id")]
[value = json.get(item, "init")]
[switchToken(current)]
[addToInitiative()]
[setInitiative(value)]
}]

The error message I get is

Code: Select all

net.rptools.parser.ParserException: Unknown JSON type "init" in function "json.sort"

I'm using "init" inside the json.sort function as the key to be used for sorting. What's happening?

[aliasmask]

I think this is why: http://forums.rptools.net/viewtopic.php ... 62#p250959

I don't think there is an easy work around, but it would involve a couple of loops and rewriting the structure. Bubble sort is one algorithm.

[Barlie]

I think this is why: http://forums.rptools.net/viewtopic.php ... 62#p250959

I don't think there is an easy work around, but it would involve a couple of loops and rewriting the structure. Bubble sort is one algorithm.

Sadly I'm not seeing a sort function for string properties. I *think* I'm seeing a way to rewrite these, as you say, by using a couple of loops to sort a string list of token ids according to a sorted string list of initiatives. But if this bug is going to get sorted out (see what I did there?) anyway, I'll probably just keep writing macros in b89 and switch over once its fixed.

[metatheurgist]

Maybe an override of json.sort() using the following functions might work as a temp fix?

json.toList()
listSort()
json.fromList()

[wolph42]

Maybe an override of json.sort() using the following functions might work as a temp fix?

json.toList()
listSort()
json.fromList()

no thats not gonna work due to the key value pair in the array which is sorted by its key. As AM says, there really aint a simple solution to this. Which makes this a big issue.

[wolph42]

and here is the 'less easy' solution: http://forums.rptools.net/viewtopic.php?f=20&t=24882