RPTools.net

Discussion and Support

Skip to content

It is currently Sun Mar 26, 2017 11:37 pm 






Reply to topic  [ 13 posts ] 

Previous topic | Next topic 

  Print view

Author Message
User avatar  Offline
Giant
 
Joined: Wed May 19, 2010 11:51 am
Posts: 166
Location: Stouffville, Ontario, Canada
 Post subject: [Rumble 5.1.1] High Crit Weapon damage
PostPosted: Wed Mar 16, 2011 10:22 pm 
Hello Rumble, et al.

I think I might have found a little bug. I have a token attacking with a High Crit Weapon. From what I can tell the framework is adding 1d12 damage on a critical hit. The weapon equipped does d12 damage. The issue I have is; the token/player is level 17, and should be getting an extra 2d12 (and 3d12 at Epic levels) on critical hits. I have checked at different levels, and this extra damage does not increase like it should.

High Crit wrote:
A high crit weapon deals more damage when you score a critical hit with it. A critical hit deals maximum weapon damage and an extra 1[W] at 1st–10th levels, an extra 2[W] at 11th–20th levels, and an extra 3[W] at 21st–30th levels. This extra damage is in addition to any critical damage the weapon supplies if it is a magic weapon.


Below are a few outputs from powers after rolling a 20. I have marked what I assume is the High Crit damage, (when I turn off the High Crit indicator this goes away).
Attachment:
Tiamat Crit issues.PNG
Tiamat Crit issues.PNG [ 94.37 KiB | Viewed 2418 times ]


Have I done something wrong again, or is this a bug?

Thanks as always for the wonderful framework and support.

FYI: This is not "Tiamat"; Tiamat is just the name a co-player gave his Dragonborn Fighter cause he liked the name. :oops:


Top
 Profile  
 
User avatar  Offline
Giant
 
Joined: Wed Dec 09, 2009 4:44 pm
Posts: 126
 Post subject: Re: [Rumble 5.1.1] High Crit Weapon damage
PostPosted: Thu Mar 17, 2011 5:54 am 
Deadolus wrote:

Have I done something wrong again, or is this a bug?

Thanks as always for the wonderful framework and support.

FYI: This is not "Tiamat"; Tiamat is just the name a co-player gave his Dragonborn Fighter cause he liked the name. :oops:


Nope u r right pal :)
My group hasn't reached paragon tier yet so I haven't noticed it.

_________________
Let's share our creativity: http://cid-be06ec931d4a4fa5.office.live ... e%20Tokens
http://groups.google.com/group/tokensrumble


Top
 Profile  
 
User avatar  Offline
Deity
 
Joined: Tue Jul 01, 2008 6:48 pm
Posts: 6237
 Post subject: Re: [Rumble 5.1.1] High Crit Weapon damage
PostPosted: Thu Mar 17, 2011 6:45 am 
It's a bug; it seems that I totally missed the part of the D&D rules where high crit damage increased per tier, so the code only adds an extra W to the damage. Should be reasonably easy to fix.

_________________

What I'm Working On

MapTool Tutorials:
Introduction to Tokens
Introduction to Properties
Introduction to Macro Writing
Introduction to Light and Sight


Top
 Profile  
 
User avatar  Offline
Giant
 
Joined: Wed May 19, 2010 11:51 am
Posts: 166
Location: Stouffville, Ontario, Canada
 Post subject: Re: [Rumble 5.1.3] High Crit Weapon damage
PostPosted: Tue Jun 07, 2011 8:41 pm 
Rumble wrote:
It's a bug; it seems that I totally missed the part of the D&D rules where high crit damage increased per tier, so the code only adds an extra W to the damage. Should be reasonably easy to fix.

Was this fixed? I am still seeing 1d# on Critical with High Crit Weapons on paragon level tokens.


Top
 Profile  
 
User avatar  Offline
Deity
 
Joined: Tue Jul 01, 2008 6:48 pm
Posts: 6237
 Post subject: Re: [Rumble 5.1.1] High Crit Weapon damage
PostPosted: Tue Jun 14, 2011 10:22 am 
Fixed. Replace the macros getDamageAoe and getDamageNonAoe with the corresponding versions attached here.


getDamageNonAoe.fix20110614.mtmacro [998 Bytes]
Downloaded 111 times
getDamageAoe.fix20110614.mtmacro [1012 Bytes]
Downloaded 106 times

_________________

What I'm Working On

MapTool Tutorials:
Introduction to Tokens
Introduction to Properties
Introduction to Macro Writing
Introduction to Light and Sight
Top
 Profile  
 
User avatar  Offline
Giant
 
Joined: Wed May 19, 2010 11:51 am
Posts: 166
Location: Stouffville, Ontario, Canada
 Post subject: Re: [Rumble 5.1.1] High Crit Weapon damage
PostPosted: Tue Jun 14, 2011 11:22 am 
Rumble wrote:
Rumble
Deity

Gotta agree with the rank here.

Thank you! I'll test it tomorrow night and report back.


Top
 Profile  
 
User avatar  Offline
Giant
 
Joined: Wed May 19, 2010 11:51 am
Posts: 166
Location: Stouffville, Ontario, Canada
 Post subject: Re: [Rumble 5.1.1] High Crit Weapon damage
PostPosted: Tue Jun 14, 2011 9:49 pm 
Deadolus wrote:
Rumble wrote:
Rumble
Deity

Gotta agree with the rank here.

Thank you! I'll test it tomorrow night and report back.

Works great! Thanks again.


Top
 Profile  
 
User avatar  Offline
Cave Troll
 
Joined: Tue Dec 07, 2010 4:46 am
Posts: 82
 Post subject: Re: [Rumble 5.1.1] High Crit Weapon damage
PostPosted: Wed Jun 15, 2011 6:02 am 
Dumb question: How do I go about replacing macros?

If I click the attached file, it asks me where to save it. I can't see a suitable location.

Edit: Figured it out. For those who are as clueless as me:

Download the fix files and save them somewhere obvious (like your desktop). Then find the macro group 'User-defined functions - Attack Handling' in the selection window of the Lib:4e token.

In the group, delete the existing getDamageAoe and getDamageNonAoe macros, then right click on a blank spot in the group. Choose 'import', then import each of the new macros from where you saved them. Once you're sure you've done it right (I recommend testing with a level 11 token with a high crit weapon), save your campaign file. Done!


Top
 Profile  
 
User avatar  Offline
Dragon
 
Joined: Tue Feb 07, 2006 12:55 pm
Posts: 383
 Post subject: Re: [Rumble 5.1.1] High Crit Weapon damage
PostPosted: Wed Jun 15, 2011 6:19 pm 
Rumble, are you maintaining a current (latest) version of the framework. I've notice a few bug fix macros appearing in various threads but I'm lost as to which I've added and those I've missed.

-- AidyBaby --

_________________
D&D qualities are related inversely to those of Poker... and I love both.
http://www.yorkpoker.co.uk


Top
 Profile  
 
User avatar  Offline
Deity
 
Joined: Tue Jul 01, 2008 6:48 pm
Posts: 6237
 Post subject: Re: [Rumble 5.1.1] High Crit Weapon damage
PostPosted: Thu Jun 16, 2011 7:02 am 
AidyBaby wrote:
Rumble, are you maintaining a current (latest) version of the framework. I've notice a few bug fix macros appearing in various threads but I'm lost as to which I've added and those I've missed.

-- AidyBaby --


Not in an organized fashion. I think I uploaded the framework with the changes I just made to the download site, but I didn't change the number.

Note also that there's a whole thread of mods/changes also, which I'm not doing anything with.

_________________

What I'm Working On

MapTool Tutorials:
Introduction to Tokens
Introduction to Properties
Introduction to Macro Writing
Introduction to Light and Sight


Top
 Profile  
 
User avatar  Offline
Cave Troll
 
Joined: Tue Dec 07, 2010 4:46 am
Posts: 82
 Post subject: Re: [Rumble 5.1.1] High Crit Weapon damage
PostPosted: Sat Jun 18, 2011 8:39 pm 
After replacing the macros, I'm now getting this error. It seems to only come up for close and area powers, so I assume it's something to do with the getDamageAoe macro.

Invalid condition in IF(matches(dcLine,".*OHCrit.*") && OHHighCrit == 1) roll option.       
Statement options (if any): if(matches(dcLine,".*OHCrit.*") && OHHighCrit == 1)       
Statement Body : dcLine = dcLine + "+" + ceiling(level/10)+"OHW"

Edit: After further testing, it's working fine with melee and ranged attacks, regardless of whether the powers are implement or weapon. It's throwing the error with close attacks regardless of whether they're implement or weapon. The only area attack I have to test it with is implement, and it throws the error.


Top
 Profile  
 
User avatar  Offline
Deity
 
Joined: Tue Jul 01, 2008 6:48 pm
Posts: 6237
 Post subject: Re: [Rumble 5.1.1] High Crit Weapon damage
PostPosted: Sun Jun 19, 2011 9:09 am 
Colmarr wrote:
After replacing the macros, I'm now getting this error. It seems to only come up for close and area powers, so I assume it's something to do with the getDamageAoe macro.

Invalid condition in IF(matches(dcLine,".*OHCrit.*") && OHHighCrit == 1) roll option.       
Statement options (if any): if(matches(dcLine,".*OHCrit.*") && OHHighCrit == 1)       
Statement Body : dcLine = dcLine + "+" + ceiling(level/10)+"OHW"

Edit: After further testing, it's working fine with melee and ranged attacks, regardless of whether the powers are implement or weapon. It's throwing the error with close attacks regardless of whether they're implement or weapon. The only area attack I have to test it with is implement, and it throws the error.


It's a cut-and-paste error; the getDamageAoe macro uses the wrong variable name, it looks like (it uses "dcLine" when the variable should be "critD").

The fix is attached - give it a try. It is interesting that you get an invalid condition error, but I just got prompts for the value of dcLine.


getDamageAoe.fix20110619.mtmacro [1003 Bytes]
Downloaded 115 times

_________________

What I'm Working On

MapTool Tutorials:
Introduction to Tokens
Introduction to Properties
Introduction to Macro Writing
Introduction to Light and Sight
Top
 Profile  
 
User avatar  Offline
Cave Troll
 
Joined: Tue Dec 07, 2010 4:46 am
Posts: 82
 Post subject: Re: [Rumble 5.1.1] High Crit Weapon damage
PostPosted: Mon Jun 20, 2011 8:17 am 
That worked. Thanks


Top
 Profile  
 
Display posts from previous:  Sort by  
Reply to topic  [ 13 posts ] 

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:

Who is online

In total there is 1 user online :: 0 registered, 0 hidden and 1 guest (based on users active over the past 5 minutes)
Most users ever online was 243 on Sun Nov 04, 2012 6:14 am

Users browsing this forum: No registered users and 1 guest





Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group

Style based on Andreas08 by Andreas Viklund

Style by Elizabeth Shulman