RPTools.net

Discussion and Support

Skip to content

It is currently Sat Nov 18, 2017 1:15 am 






Reply to topic  [ 8 posts ] 

Previous topic | Next topic 

  Print view

Author Message
User avatar  Offline
Giant
 
Joined: Wed May 19, 2010 11:51 am
Posts: 166
Location: Stouffville, Ontario, Canada
 Post subject: [Rumble 5.1.3]: Triggering Text posted from Effect text
PostPosted: Tue Nov 06, 2012 10:35 pm 
Hello Rumble and all those that work to maintain and improve Rumble's frameworks. I know Rumble has taken hiatus from fixing bugs, though I think this one might be minor to fix... If he or anyone savvy enough can post the fix, it would help avoid some confusion during sessions.

Here is the issue;

Some powers with "Trigger" text, post the "Effect" text in the chat in place of the trigger text. Here is an example...
Attachment:
Wrong trigger displayed.png
Wrong trigger displayed.png [ 67.06 KiB | Viewed 1506 times ]


Because the CAMPAIGN FRAMEWORKS ‹ D&D 4E FRAMEWORKS forum is locked, I am posting here in the hopes the Admin's will move it, and/or someone will answer / provide a fix.

Thanks all!


Last edited by aliasmask on Tue Nov 06, 2012 10:42 pm, edited 1 time in total.
Moved from User Creations to FW/D&D 4E


Top
 Profile  
 
User avatar  Offline
Great Wyrm
 
Joined: Tue Aug 23, 2011 10:41 am
Posts: 1134
Location: Cornwall, UK
 Post subject: Re: [Rumble 5.1.3]: Triggering Text posted from Effect text
PostPosted: Tue Nov 06, 2012 10:47 pm 
Even if I cannot help, I wanted to congratulate you on your exemplary bug post. If every user posted bugs in this way, they'd be much easier to hunt and fix.

_________________
How to get around the two code nest limit in MapTool (and MOTE)


Top
 Profile  
 
User avatar  Offline
Giant
 
Joined: Wed May 19, 2010 11:51 am
Posts: 166
Location: Stouffville, Ontario, Canada
 Post subject: Re: [Rumble 5.1.3]: Triggering Text posted from Effect text
PostPosted: Tue Nov 06, 2012 11:29 pm 
Bone White wrote:
Even if I cannot help, I wanted to congratulate you on your exemplary bug post. If every user posted bugs in this way, they'd be much easier to hunt and fix.

Thanks, I have become quite good and complaining.


Top
 Profile  
 
User avatar  Offline
Giant
 
Joined: Fri Sep 09, 2011 3:41 am
Posts: 176
Location: Honolulu, HI
 Post subject: Re: [Rumble 5.1.3]: Triggering Text posted from Effect text
PostPosted: Thu Nov 08, 2012 5:54 am 
I use a modified version of this framework, but no changes in that area that I recall. However, I can't seem to reproduce this bug. Could you post the "Conditions applied to allies" subsection so I can have a look?

To be clear, you're clicking the power to trigger it, correct? Can you also post a screenshot of what the power shows when you click it?

Attachment:
2012-11-08_0044.png
2012-11-08_0044.png [ 22.01 KiB | Viewed 1480 times ]


Attachment:
2012-11-08_0044_001.png
2012-11-08_0044_001.png [ 7.68 KiB | Viewed 1480 times ]

_________________
My stuff:
Translation (Font) Tool
Custom Mods for Rumble's 4e Framework


Top
 Profile  
 
User avatar  Offline
Dragon
 
Joined: Mon Jul 18, 2011 12:10 pm
Posts: 688
Location: Toronto
 Post subject: Re: [Rumble 5.1.3]: Triggering Text posted from Effect text
PostPosted: Fri Nov 09, 2012 1:24 am 
Fixed. Vhex, I confirmed your findings as I don't get the trigger line either. I suspect he is using a modified version too. I added this line to the beginning of AttackPost to extract the info from the "currentPowerInfo" JSON:

Code:
[h:trigger=json.get(currentPowerInfo, "trigger")]


... and this one to the beginning of the "[r,if(isPC()),CODE:" block near the end:

Code:
[r:if(trigger != "--none--" && trigger != 0, "<b>Trigger</b>: "+trigger+"<br>", "")]


In his modified version, I am guessing the programmer just copied and pasted the "[r:if(alwaysEff != "--none--" && alwaysEff != 0, "<b>Effect</b>: "+alwaysEff+"<br>", "")]" line but only changed the "<b>Effect</b>" part.

PS: Yes, I said I would never touch Rumble's code. Deadolus, consider this a favor for old time's sake. I leave further modifications in the capable hands of LongShot and others.


File comment: Replace Lib:4e in Rumble 5.1.3 with this one.
Lib4e-StarMan.rptok [227.49 KiB]
Downloaded 104 times

_________________
StarMan - The MacroPolicebox D&D 4E Framework: Import ANYTHING!
Top
 Profile  
 
User avatar  Offline
Giant
 
Joined: Wed May 19, 2010 11:51 am
Posts: 166
Location: Stouffville, Ontario, Canada
 Post subject: Re: [Rumble 5.1.3]: Triggering Text posted from Effect text
PostPosted: Fri Nov 09, 2012 12:20 pm 
Thanks guys!

I tried to reproduce this at home, and also could not. Must be an issue with the DM's copy of the Lib Files (which he got from me at some point).

Thanks for the time and effort (and personal policy infringement) it is appreciated.
Deadolus


Top
 Profile  
 
User avatar  Offline
Giant
 
Joined: Fri Sep 09, 2011 3:41 am
Posts: 176
Location: Honolulu, HI
 Post subject: Re: [Rumble 5.1.3]: Triggering Text posted from Effect text
PostPosted: Fri Nov 09, 2012 2:59 pm 
StarMan -- It occurs to me that showing the trigger is probably a good idea for ease of tracking down where stuff came from. I stole your fix. Just a quick note -- in the interest of HTML compatibility <br> should be <br />. It doesn't matter right now, but it's code correct and a good habit to get into. Thanks for the code!

Deadolus -- I noticed one other minor bugs that I hadn't seen before while looking at this. When you edit a power and click on the Trigger Line, it says "Special Notes" instead of trigger. You can change that by opening the Lib:Power4e library and, under Power Selection Editors, modifying the EditTriggers macro.

Replace:
Code:
"newTrig|"+trig+"|Enter special notes text for "+powerName)]

With:
Code:
"newTrig|"+trig+"|Enter trigger text for "+powerName)]


There's also the issue that in order for you to get the item power to show yellow -- you made it a consumable. I think when Rumble originally coded it, he didn't really care where the item power came from if it was reusable, but I can see the appeal of knowing at a glance that it's an item power. That's a quick fix that I may do, just to give you the option to change the color without having to make it a consumable.

_________________
My stuff:
Translation (Font) Tool
Custom Mods for Rumble's 4e Framework


Top
 Profile  
 
User avatar  Offline
Giant
 
Joined: Wed May 19, 2010 11:51 am
Posts: 166
Location: Stouffville, Ontario, Canada
 Post subject: Re: [Rumble 5.1.3]: Triggering Text posted from Effect text
PostPosted: Sat Nov 10, 2012 4:32 pm 
Vhex wrote:
There's also the issue that in order for you to get the item power to show yellow -- you made it a consumable. I think when Rumble originally coded it, he didn't really care where the item power came from if it was reusable, but I can see the appeal of knowing at a glance that it's an item power. That's a quick fix that I may do, just to give you the option to change the color without having to make it a consumable.

Thanks, the change works well for item properties and At-Will powers.... Daily powers need to be black so you know if you have used the power during your day... unless you give yourself an inventory of 1 each day... I don't bother with that though.

Thanks again for your help (both of you).


Top
 Profile  
 
Display posts from previous:  Sort by  
Reply to topic  [ 8 posts ] 

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:

Who is online

In total there is 1 user online :: 0 registered, 0 hidden and 1 guest (based on users active over the past 5 minutes)
Most users ever online was 243 on Sun Nov 04, 2012 6:14 am

Users browsing this forum: No registered users and 1 guest





Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group

Style based on Andreas08 by Andreas Viklund

Style by Elizabeth Shulman