Hi there!
I've been a user of RPTools (especially MapTool) for a long time. I've submitted a code patch years ago and wanted to get back into it, at least a little. So how does it work now? Is it OK if I just pick an issue from GitHub that's assigned to nobody and submit a pull request, once I got it down? Or do you have some kind of process to accept/decline issues?
Hello again
Moderators: dorpond, trevor, Azhrei
Hello again
The only valid measurement of code quality: WTFs / minute
Re: Hello again
Yes, please do. Grab a fork from Github and tuck in
If you had time to tackle any of the outstanding issues currently logged on GitHub people would be very happy.
(Example: https://github.com/RPTools/maptool/issues/198)
The only submission process is an informal peer-review with Az and Craig having the final say. Basically you submit a Pull Request, anyone with Dev status gets a chance to review (which is usually helpful as opposed to adversarial) but Az gets the final say as he controls the offical build process.
If you had time to tackle any of the outstanding issues currently logged on GitHub people would be very happy.
(Example: https://github.com/RPTools/maptool/issues/198)
The only submission process is an informal peer-review with Az and Craig having the final say. Basically you submit a Pull Request, anyone with Dev status gets a chance to review (which is usually helpful as opposed to adversarial) but Az gets the final say as he controls the offical build process.
- JamzTheMan
- Great Wyrm
- Posts: 1872
- Joined: Mon May 10, 2010 12:59 pm
- Location: Chicagoland
- Contact:
Re: Hello again
And before working on it, it would be appreciated if you assigned the issue to yourself. You could also comment on it and if it's complicated, a plan of attack. Most of us get emails/alerts when Issues are updated and respond right back to the issue with comments/suggestions.
-Jamz
____________________
Custom MapTool 1.4.x.x Fork: maptool.nerps.net
Custom TokenTool 2.0 Fork: tokentool.nerps.net
More information here: MapTool Nerps! Fork
____________________
Custom MapTool 1.4.x.x Fork: maptool.nerps.net
Custom TokenTool 2.0 Fork: tokentool.nerps.net
More information here: MapTool Nerps! Fork
Re: Hello again
Unless I am missing a bit of the UI, I don't think anyone but the repo owners can assign Issues.
At least, I haven't been able to work out how to grab an issue.
At least, I haven't been able to work out how to grab an issue.
- JamzTheMan
- Great Wyrm
- Posts: 1872
- Joined: Mon May 10, 2010 12:59 pm
- Location: Chicagoland
- Contact:
Re: Hello again
That could be true... So if you just comment you are working on it one of the admins can "assign" the issue to you.
-Jamz
____________________
Custom MapTool 1.4.x.x Fork: maptool.nerps.net
Custom TokenTool 2.0 Fork: tokentool.nerps.net
More information here: MapTool Nerps! Fork
____________________
Custom MapTool 1.4.x.x Fork: maptool.nerps.net
Custom TokenTool 2.0 Fork: tokentool.nerps.net
More information here: MapTool Nerps! Fork
Re: Hello again
This a great thread--I'm in the same position as @Cronk, having not participated since 2012...
Sounds good: find an issue, add a comment that you are working on it, submit a PR.
Sounds good: find an issue, add a comment that you are working on it, submit a PR.