BUG: ParserExceptions handled incorrectly

Developer discussion regarding MapTool 1.4

Moderators: dorpond, trevor, Azhrei

Forum rules
Posting now open to all registered forum users.
Post Reply
User avatar
Jagged
Great Wyrm
Posts: 1306
Joined: Mon Sep 15, 2008 9:27 am
Location: Bristol, UK

BUG: ParserExceptions handled incorrectly

Post by Jagged »

So I am playing with script functions at the moment and many of them throw ParserExceptions, typically if they are given the wrong number of parameters.

However when I try and force this error in 1.4 (and in 1.3b91) I get a message like:

Code: Select all

Error in body of roll.
  Statement options (if any): r
  Statement Body : getCurrentMapName(2,3)
and not the nicely formatted message from the I18N file. Anyone else having this problem?
Last edited by Jagged on Tue May 05, 2015 6:32 am, edited 1 time in total.

User avatar
Jagged
Great Wyrm
Posts: 1306
Joined: Mon Sep 15, 2008 9:27 am
Location: Bristol, UK

Re: Question about ParserException

Post by Jagged »

No responses? It would be helpful if people could try entering the following:

Code: Select all

[r:getCurrentMapName(2,3)]
This should force a ParserException error, then tell me if you get a nice formatted error message or the "Error in body of roll" as above?

In 1.3b91 or 1.4, either would help.

cheers

User avatar
aliasmask
RPTools Team
Posts: 9024
Joined: Tue Nov 10, 2009 6:11 pm
Location: Bay Area

Re: Question about ParserException

Post by aliasmask »

b91 & 1.4.0.initial-a9c5ea4

Code: Select all

   Error in body of roll.
       Statement options (if any): r
       Statement Body : getCurrentMapName(2,3)
Point me to the link if there is a newer build of 1.4. This one is dated 2015-04-28

User avatar
Jagged
Great Wyrm
Posts: 1306
Joined: Mon Sep 15, 2008 9:27 am
Location: Bristol, UK

Re: Question about ParserException

Post by Jagged »

Thanks for that. I think that is the latest version.

If you are getting the same error, then its not just me :D and I am willing to formally declare it a bug :(

I expect we will have to wait until Craig has added the ParserLib project to Git Hub, before we can address this problem.

User avatar
RPTroll
TheBard
Posts: 3159
Joined: Tue Mar 21, 2006 7:26 pm
Location: Austin, Tx
Contact:

Re: BUG: ParserExceptions handled incorrectly

Post by RPTroll »

This is now 32.4 with a Blocked status
ImageImage ImageImageImageImage
Support RPTools by shopping
Image
Image

User avatar
JamzTheMan
Great Wyrm
Posts: 1872
Joined: Mon May 10, 2010 12:59 pm
Location: Chicagoland
Contact:

Re: BUG: ParserExceptions handled incorrectly

Post by JamzTheMan »

On a "similiar" note, while you are looking around the Parser, I think I found some strangeness and it revolves around turning tool tips on/off and such.

Some times people do use the notation of [somevar=52] vs [h: somevar=52] while inside another [h: if...] block. However, if you use [thisVar=52] it looks like it picks this up as a "tooltip" [t:] tag depending on your preferences setting.

I was in the code trying to fix/enhance better html comment handling, eg <!-- --> and notice it could use some loving.

Not sure if anyone else has confirmed/noticed this?
-Jamz
____________________
Custom MapTool 1.4.x.x Fork: maptool.nerps.net
Custom TokenTool 2.0 Fork: tokentool.nerps.net
More information here: MapTool Nerps! Fork

User avatar
Jagged
Great Wyrm
Posts: 1306
Joined: Mon Sep 15, 2008 9:27 am
Location: Bristol, UK

Re: BUG: ParserExceptions handled incorrectly

Post by Jagged »

A fix for this bug has been submitted.

User avatar
RPTroll
TheBard
Posts: 3159
Joined: Tue Mar 21, 2006 7:26 pm
Location: Austin, Tx
Contact:

Re: BUG: ParserExceptions handled incorrectly

Post by RPTroll »

Awesome
ImageImage ImageImageImageImage
Support RPTools by shopping
Image
Image

User avatar
JamzTheMan
Great Wyrm
Posts: 1872
Joined: Mon May 10, 2010 12:59 pm
Location: Chicagoland
Contact:

Re: BUG: ParserExceptions handled incorrectly

Post by JamzTheMan »

kudo for tackling "The Parser", I know that was fun... :D
-Jamz
____________________
Custom MapTool 1.4.x.x Fork: maptool.nerps.net
Custom TokenTool 2.0 Fork: tokentool.nerps.net
More information here: MapTool Nerps! Fork

User avatar
Full Bleed
Demigod
Posts: 4736
Joined: Sun Feb 25, 2007 11:53 am
Location: FL

Re: BUG: ParserExceptions handled incorrectly

Post by Full Bleed »

JamzTheMan wrote:kudo for tackling "The Parser", I know that was fun... :D
Kudos to Jagged tackling a number of outstanding issues lately!

Now we just need someone to pump out a build. ;)
Maptool is the Millennium Falcon of VTT's -- "She may not look like much, but she's got it where it counts."

Post Reply

Return to “MapTool 1.4”