Page 4 of 4

Re: Upgrade complete (?)

Posted: Wed May 16, 2018 3:45 am
by wolph42
@Azhrei: so what is the status of the spoiler tag, cause when I check my BoT post their still not working.

Re: Upgrade complete (?)

Posted: Wed May 16, 2018 4:45 pm
by Azhrei
Should be working. The previous posts in this thread are working fine. I'll take a look at the threads in your signature when I get a chance to see what might be different. (You can also try clearing the browser cache, as some of the spoiler stuff is done using JavaScript.)

Re: Upgrade complete (?)

Posted: Thu May 17, 2018 5:01 am
by wolph42
cleared the cache...no cigar: viewtopic.php?p=170978
test
can test it here obviously, edit: weird, this one is working...
edit: ok after ADDING a spoiler (probably due to actually editing) did the other spoilers activate. I'll check my other threads now as well.
edit2: nope ONLY when I add new spoiler tags do the other spoilers activate. if I just edit the text, the spoilers remain inactive.

I'll leave this one for you to check what is going on:
viewtopic.php?f=8&t=16833&start=0

Re: Upgrade complete (?)

Posted: Thu May 17, 2018 6:39 am
by Full Bleed
wolph42 wrote:
Thu May 17, 2018 5:01 am
cleared the cache...no cigar: viewtopic.php?p=170978
test
can test it here obviously, edit: weird, this one is working...
edit: ok after ADDING a spoiler (probably due to actually editing) did the other spoilers activate. I'll check my other threads now as well.
edit2: nope ONLY when I add new spoiler tags do the other spoilers activate. if I just edit the text, the spoilers remain inactive.

I'll leave this one for you to check what is going on:
viewtopic.php?f=8&t=16833&start=0
I've seen other old posts with spoiler tags that aren't working, too.

You can do a

Code: Select all

[spoiler]
search and find lots of them.

Re: Upgrade complete (?)

Posted: Thu May 17, 2018 10:46 am
by Azhrei
Hm, that's strange. The spoiler stuff is actually done when the post is read from the database and converted to HTML to send to the browser. So editing the content of the post shouldn't be triggering anything??

I could understand if using a spoiler tag somehow caused a flag to be set when the post was submitted, but there is no such flag. I'll have to look into the spoiler extension and see how it works; maybe it's somehow looking at the date the extension was installed and comparing that to the last update time on the post? (But then editing a post would be required and sufficient...)

I'll let you know what I find out, but it'll be the weekend before I can start looking into this.

Edit: I looked at the post you linked to, and I see what you mean. It appears though, that if you don't make any change, the submit button doesn't actually send anything back to the server. That could be significant because the update timestamp on the post wouldn't change. Thanks for the link. :)

Re: Upgrade complete (?)

Posted: Fri May 18, 2018 8:53 am
by Full Bleed
I think I found an issue with existing attachments, too.

Take a look at this post: viewtopic.php?f=86&t=27253&p=267209#p267209

You can't download the attachment.

I edited the post and could download it from there (so the file is still in the DB and accessible.) And I tried adding some text to the attachment name ("Fix Attachment") and saving the edit but it's still not downloadable.