[1.3b56] Fine drawing and vbl bugs (list of them)

[galneweinhaw]

While resolving this minor issue:
http://forums.rptools.net/viewtopic.php?f=21&t=7523

I noticed a pile of other fine-scale drawing bugs. I'm going to use this as a place to document them. Most are related and easy to fix now that I'm knees deep in this area of the code.

I'm using a 5px grid only so that it's easy to see the differences with a small grid. Many of these I have found frusterating, especially when trying to get accurate VBL.

The black cross seperates the grid and zone quadrants.

Please post if you know of any other little buggers.

1. Drawing tools offset up and to the left in all quadrants. The images should be in the grid square, or on the grid line for the line.

offsetUpAndLeft.jpg (36.41 KiB) Viewed 1493 times

EDIT: Resolved, patch results in correct behaviour below:

DrawingOffsetCorrected.jpg (35.67 KiB) Viewed 1485 times

2. VBL rectangle preview while drawing doesn't match resulting VBL. Also, offset up and left like drawing tools are. This happens in all four quadrants: Shows while drawing(red), then as drawn (blue)

DrawVBL.jpg (8.49 KiB) Viewed 1493 times

VBL.jpg (7.69 KiB) Viewed 1493 times

EDIT: Resolved, patch results in correct behaviour below, actaul VBL is identical to the preview.

VBLPreviewFix.jpg (9.41 KiB) Viewed 1487 times

[galneweinhaw]

3. Oval VBL changes shape and shifts down/right/both depending on the quadrant. #1 and #2 above also occur. These were drawn with the expectation that they would fill (with an oval) the first four squares of each quadrant:

OvalVBL.jpg (25.3 KiB) Viewed 1496 times

Resolved:

OvalVBLPatched.jpg (23.77 KiB) Viewed 1487 times

[Azhrei]

(Can only do 3 images in a post =)

(Corrected. The attachment limit is now 8 images per post and 2 for a PM. Hopefully the image limits are not something spammers are looking for. )

[galneweinhaw]

Thanks Azhrei, that make things easier!

All above have now been resolved and will be included in my next patch.

[hyperactiveChipmunk]

I think I love you.

*hug*?

-hC

[trevor]

Applied to 1.3b57