[1.3b86] Bug: undo drawing remembers Everything!

Thoughts, Help, Feature Requests, Bug Reports, Developing code for...

Moderators: dorpond, trevor, Azhrei

Forum rules
PLEASE don't post images of your entire desktop, attach entire campaign files when only a single file is needed, or generally act in some other anti-social behavior. :)
Post Reply
User avatar
patoace
Dragon
Posts: 313
Joined: Mon Sep 24, 2007 6:10 pm
Location: Rancagua - Chile

[1.3b86] Bug: undo drawing remembers Everything!

Post by patoace »

To reproduce:

1. Start Maptool
2. Select Drawing tool
3. Draw a shape in any layer
4. Hit ctrl-Z or Edit>>Undo, your shape disappears.
5. Draw a new shape

In 1.3b86, Maptool shows the first drawing, from step 3, and not the new one, from step 5. If you then draw a third shape, it shows second and third shapes but the first one disappears. Similar behavior can be seen with the template tools.

This bug isn't present in 1.3b84.

User avatar
LaserWolf
Dragon
Posts: 258
Joined: Wed Jul 16, 2008 2:12 pm
Location: Durham, NC, USA
Contact:

Re: [1.3b86] Bug: undo drawing remembers Everything!

Post by LaserWolf »

I can confirm that one of my players experienced this the other day. She couldn't articulate exactly what was going wrong but was very frustrated about it. Looking at Patoace's post I think that's exactly what happened.

User avatar
Rumble
Deity
Posts: 6235
Joined: Tue Jul 01, 2008 7:48 pm

Re: [1.3b86] Bug: undo drawing remembers Everything!

Post by Rumble »

Confirmed. It will repeat twice, in fact:

1. Draw shape #1.
2. Hit Undo.
3. Draw Shape #2. Result: Shape #1 is drawn.
4. Draw Shape #3. Result: Shape #2 is drawn.

However, it only seems to happen if you draw a single shape, then hit Undo, and it stops after shape #2.

If you draw multiple shapes before hitting Undo, it works like you'd expect.

I'd put this in the Showstopper category.



Edited for clarity

User avatar
LaserWolf
Dragon
Posts: 258
Joined: Wed Jul 16, 2008 2:12 pm
Location: Durham, NC, USA
Contact:

Re: [1.3b86] Bug: undo drawing remembers Everything!

Post by LaserWolf »

Agreed, Rumble! Here's the real kicker: when done on a server the GM doesn't see the same drawing as the players, AND the players may even see different drawings amongst themselves!

User avatar
wolph42
Deity
Posts: 9833
Joined: Fri Mar 20, 2009 5:40 am
Location: Netherlands
Contact:

Re: [1.3b86] Bug: undo drawing remembers Everything!

Post by wolph42 »

LaserWolf wrote:Agreed, Rumble! Here's the real kicker: when done on a server the GM doesn't see the same drawing as the players, AND the players may even see different drawings amongst themselves!


You have just entered... The Twilight Zone

User avatar
Azhrei
Site Admin
Posts: 12058
Joined: Mon Jun 12, 2006 1:20 pm
Location: Tampa, FL

Re: [1.3b86] Bug: undo drawing remembers Everything!

Post by Azhrei »

Just posting to let you know I've seen this thread. I'll investigate.

User avatar
LaserWolf
Dragon
Posts: 258
Joined: Wed Jul 16, 2008 2:12 pm
Location: Durham, NC, USA
Contact:

Re: [1.3b86] Bug: undo drawing remembers Everything!

Post by LaserWolf »

All anecdotal evidence from me far. I'll see what I can do to replicate it after getting some sleep, but here's an observation.

So far I've noticed that the drawing has always looked correct on my computer (whether I'm a player or GM), even if it looks incorrect to the person drawing it. In other words, a GM or player attempts to draw a burst and it shows up in the wrong location on their local computer, but is exactly where they describe placing it on my machine. The few times I have drawn a burst (which I've only done as a GM), they have shown up in the correct location for everyone.

I don't know the code, but that suggests to me that the drawings are offset based on a local setting that's taking precedence over the server setting. Something that's correctly (or at least consistently) set on my computer, but not others. The issue doesn't fall strictly along GM/player lines or server/client lines. I've seen two distinctly wrong locations show up for a single drawing, in tandem with the correct one.

I'll try asking my players for their local settings if it's not nailed down soon.

User avatar
Rumble
Deity
Posts: 6235
Joined: Tue Jul 01, 2008 7:48 pm

Re: [1.3b86] Bug: undo drawing remembers Everything!

Post by Rumble »

That sounds like a second but related issue - for me, I was drawing shapes (rectangles, to be specific), just on a single instance of MapTool, and it was definitely remembering the previous shape - it wasn't the new shape, but offset. However, that's a client/server issue too.

Weird bug. Good luck, Azhrei!

User avatar
patoace
Dragon
Posts: 313
Joined: Mon Sep 24, 2007 6:10 pm
Location: Rancagua - Chile

Re: [1.3b86] Bug: undo drawing remembers Everything!

Post by patoace »

Azhrei wrote:Just posting to let you know I've seen this thread. I'll investigate.


Thank you Azhrei. I'm glad to help in some way to Maptool.

User avatar
LaserWolf
Dragon
Posts: 258
Joined: Wed Jul 16, 2008 2:12 pm
Location: Durham, NC, USA
Contact:

Re: [1.3b86] Bug: undo drawing remembers Everything!

Post by LaserWolf »

Yeah that does seem different from the issue you two are describing. Sorry for the confusion!

User avatar
Rumble
Deity
Posts: 6235
Joined: Tue Jul 01, 2008 7:48 pm

Re: [1.3b86] Bug: undo drawing remembers Everything!

Post by Rumble »

LaserWolf wrote:Yeah that does seem different from the issue you two are describing. Sorry for the confusion!


Could be related, though, so it's good to have all the input. I never checked to see what players saw when I was confirming the initial report.

Post Reply

Return to “MapTool”