Macro edit window default position

[Bone White]

This has been irritating me for the last few days, but I finally figured out how to fix it. My macro edit window was drawing so low down that ok and cancel were drawn behind my taskbar, so I either had to drag the window out every time or use ctrl+enter to submit the changes. I tried re-installing MapTool and all sorts of other things, but what finally fixed it was closing the edit macro window with the X in the top right. This makes MapTool remember the size of the window and the location.

Thought this might be useful for people to search for on the forums to find the answer, or for anyone else having the same problem.

[wolph42]

Join the club. I figured this out and posted it 1.5 years ago. But it's good to bump this from time to time. Note that it also works if you close the window by double clicking thumper left corner.

[Bone White]

I did try searching both in forums and using google to site search, oh well.

[wolph42]

I did try searching both in forums and using google to site search, oh well.

I know, what on earth will your search string be for this one??!

[Bone White]

Hopefully two or more of the five words in the title <_<

[Azhrei]

[...] what finally fixed it was closing the edit macro window with the X in the top right. This makes MapTool remember the size of the window and the location.

Sounds like a bug.

What is likely happening is that the Java object that represents the dialog (called a JDialog) is being completely destroyed when you submit it and the location is also freed up. But when you close it from the X the dialog is disposed instead and the location is retained. Seems strange though; most Swing components don't work like that. (Although dialogs are different from regular Swing components in quite a few ways.) I'll take a look at the code.

[Bone White]

Note that the same applies to the cancel button Az. We're not asking for a fix because the work around is so simple, but we appreciate your eagerness.

[Azhrei]

Something strange is going on. The existing code calls both setVisible(false) and dispose() on the dialog when the OK or Cancel buttons are used. By default, the Close button in the titlebar only causes setVisible(false).

So, logically, I should be able to remove the dispose() and get the same behavior, but that doesn't work. The Close button remembers the location of the dialog and the OK and Cancel do not. There's still something else going on. I'll continue to look into this over the next day or two.

[username]

The x goes through a different path on the OS window manager than the ok and cancel. That may make the difference.

[Azhrei]

Ah, very likely. To really check this I'll need to run it on other OSes and see (it will be awhile before I get to that though).

Great catch.

[Xaelvaen]

This same issue/fix works on other frames as well. For the longest time, my custom character sheet frame just would not remember its location. It remembers the size, but never the relative position. However, thanks to reading this post, x-canceling the frame and then saving the campaign worked well. It now remembers its location.