json tables problem

wisewolf · Post by **wisewolf** » Wed Dec 11, 2019 2:50 am

My second question

In the Runequest campaign I have a problem when showing json tables. I am really new to this so I can't see where is the problem. For example, with wepons, the json looks this way (I only copy a single weapon so it is not too long):

Code: Select all

[{"Nom":"Alabarda","Mains":"2H","Competence":"Estilo: Close Combat","Category":"Close Combat","Degats":"1D8+2","Type":"Yes","Portee":2.5,"Attaques par Round":"1","Recharge":"0","Munitions":"0","Enrayement":"0","Bonus/Malus":"0","Epoque":"Runequest","Notes":"Can be set against a charge  ","Manoeuvres":"Atrapar","STR":7,"DEX":7,"Taille":"G","Allonge":"ML","PA":4,"PV":10,"Perce-Armure":"0","Description":"An axe head combined with a thrusting tip and a hook, mounted on a spear shaft, the halberd is a multi-purpose weapon. Halberdiers are versatile opponents that can bring any version of the weapon&#39s attack to bear in an instant. ","Prix":"250","Monnaie":"SP","Poids":"4"},

I have attached a screenshot to see how it is shown.

Here is the macro call:

Code: Select all

[h:AllWeapons=getLibProperty(&quot;AllWeapons&quot;,&quot;Lib:gm&quot;)]

[frame(&quot;Weapons&quot;,&quot;temporary=0&quot;):
{
	[macro(&quot;JsonToTable@lib:gm&quot;):AllWeapons]					
}]

And here is the macro:

Code: Select all

[h:jsonarray=Macro.args]
[h:jsonarraylength=json.length(jsonarray)]
[h:jsonobject=json.get(jsonarray,0)]
[h:jsonobjectfields = json.fields(jsonobject)]
[h:jsonobjectattrib = json.get(jsonobject,&quot;Nom&quot;)]
[h:jsonobjectlength=json.length(jsonobject)]

[h:numberOfRows = jsonarraylength]
[h:numberOfColumns = jsonobjectlength]

[h: oddRow = &apos;#FFFFFF&apos;]
[h: evenRow = &apos;#EEEEAA&apos;]

&lt;html&gt;
&lt;head&gt;
&lt;title&gt;Tableau&lt;/title&gt;
&lt;link rel=&quot;stylesheet&quot; type=&quot;text/css&quot; href=&quot;generic_css@Lib:gm&quot;&gt;&lt;/link&gt;
&lt;/head&gt;
&lt;body&gt;
&lt;table border=&quot;0&quot; CELLPADDING=5 Align=center width=100%&gt;
	[for(j,0,NumberOfColumns,1,&quot;&quot;):&quot;&lt;th Align=center&gt;&quot;+ listGet(jsonobjectfields,j)]&lt;/th&gt;
	[h:bgColor = oddRow]
	[for(i,0,NumberOfRows,1,&quot;&quot;),code:
		{

		[h:jsonobject=json.get(jsonarray,i)]
		[if ((i/10)==floor(i/10) &amp;&amp; i!=0),CODE :
		{ 
		[for(j,0,NumberOfColumns,1,&quot;&quot;):&quot;&lt;th Align=center&gt;&quot;+ listGet(jsonobjectfields,j)]&lt;/th&gt;&lt;/tr&gt;
		};{}]
		&lt;tr&gt;
		[for(j, 0, NumberOfColumns, 1, &quot;&quot;), code:
			{
			&lt;td align=&apos;center&apos; bgcolor=[r:bgColor]&gt;&lt;span color=&apos;black&apos;&gt;&lt;b&gt;
			[h:jsonobjectattrib=listGet(jsonobjectfields,j)]
			[json.get(jsonobject,jsonobjectattrib)]	
			&lt;/td&gt;
			}]
		&lt;/tr&gt;
		[h:bgColor = if(bgColor == oddRow, evenRow, oddRow)]	
		}]	
&lt;/table&gt;
 &lt;/body&gt;
 &lt;/html&gt;

Thank you very much in advance.

wolph42 · Post by **wolph42** » Wed Dec 11, 2019 4:19 am

you didn't state what the 'problem' is that you perceive. What is it you want?

wisewolf · Post by **wisewolf** » Wed Dec 11, 2019 5:11 am

As you maybe can see on the attached screenshot, each column is shown with all the code inside every cell, where it should be shown just the "name", "damage", "reach", etc.

For example, in Category column, this is what is shown:

« json.get(jsonobject,jsonobjectattrib) = json.get({"Nom":"Alabarda","Mains":"2H","Competence":"Estilo: Close Combat","Category":"Close Combat","Degats":"1D8+2","Type":"Yes","Portee":2.5,"Attaques par Round":"1","Recharge":"0","Munitions":"0","Enrayement":"0","Bonus/Malus":"0","Epoque":"Runequest","Notes":"Can be set against a charge ","Manoeuvres":"Atrapar","STR":7,"DEX":7,"Taille":"G","Allonge":"ML","PA":4,"PV":10,"Perce-Armure":"0","Description":"An axe head combined with a thrusting tip and a hook, mounted on a spear shaft, the halberd is a multi-purpose weapon. Halberdiers are versatile opponents that can bring any version of the weapon's attack to bear in an instant. ","Prix":"250","Monnaie":"SP","Poids":"4"}, Epoque) = Runequest »

I didn't write the code so I don't know exactly what the problem is, and I am not used to json tables

It seems like it shows the complete json instead of showing just the category.

metatheurgist · Post by **metatheurgist** » Wed Dec 11, 2019 5:55 am

For starters it looks like a lot of code has been replaced by html entities. I can't believe that works at all.

wolph42 · Post by **wolph42** » Wed Dec 11, 2019 6:15 am

I did see the screenshot and I could make an educated guess what the issue was/is, but it would be exactly that: a guess. Over the years I've started to refrain from going into posts where people completely forget to ask what they want...

I noticed the html markup as well and most likely if you fix that then 'it' will be fixed.

For starters I would suggest you copy paste the code into a text editor and search and replace:

"

for

"

So this:

Code: Select all

[h:jsonobjectattrib = json.get(jsonobject,&quot;Nom&quot;)]

turns into this

Code: Select all

[h:jsonobjectattrib = json.get(jsonobject,"Nom")]

There are probably other markups as well (like '), so also do a search for & to check out the other and replace them as well. Then paste the code back and see what happens.

edit: another thing which might be quicker is to place the code in an html form, render it and then copy paste the result back. Not 100% sure though that this will go rigth (but it should).

wisewolf · Post by **wisewolf** » Wed Dec 11, 2019 6:39 am

Well it is not really that way, but when I open it with Notepad++ it shows those entities changed. Anyway inside Maptool the macros are shown with the correct entities, so it can't be the problem here.

I attach here the macro shown inside Maptool

wisewolf · Post by **wisewolf** » Wed Dec 11, 2019 7:26 am

And here in plain text

Code: Select all

[h:jsonarray=Macro.args]
[h:jsonarraylength=json.length(jsonarray)]
[h:jsonobject=json.get(jsonarray,0)]
[h:jsonobjectfields = json.fields(jsonobject)]
[h:jsonobjectattrib = json.get(jsonobject,"Nom")]
[h:jsonobjectlength=json.length(jsonobject)]

[h:numberOfRows = jsonarraylength]
[r:numberOfRows]
[h:numberOfColumns = jsonobjectlength]
[r:numberOfColumn]

[h: oddRow = '#FFFFFF']
[h: evenRow = '#EEEEAA']

<html>
<head>
<title>Tableau</title>
<link rel="stylesheet" type="text/css" href="generic_css@Lib:gm"></link>
</head>
<body>
<table border="0" CELLPADDING=5 Align=center width=100%>
	[for(j,0,NumberOfColumns,1,""):"<th Align=center>"+ listGet(jsonobjectfields,j)]</th>
	[h:bgColor = oddRow]
	[for(i,0,NumberOfRows,1,""),code:
		{

		[h:jsonobject=json.get(jsonarray,i)]
		[if ((i/10)==floor(i/10) && i!=0),CODE :
		{ 
		[for(j,0,NumberOfColumns,1,""):"<th Align=center>"+ listGet(jsonobjectfields,j)]</th></tr>
		};{}]
		<tr>
		[for(j, 0, NumberOfColumns, 1, ""), code:
			{
			<td align='center' bgcolor=[r:bgColor]><span color='black'><b>
			[h:jsonobjectattrib=listGet(jsonobjectfields,j)]
			[json.get(jsonobject,jsonobjectattrib)]	
			</td>
			}]
		</tr>
		[h:bgColor = if(bgColor == oddRow, evenRow, oddRow)]	
		}]	
</table>
 </body>
 </html>

Post by **aliasmask** » Wed Dec 11, 2019 7:40 am

I would check your preferences and make sure these settings are checked as I have them. I also recommend putting your output in to a variables and then outputting in the end.

Merudo · Post by **Merudo** » Wed Dec 11, 2019 7:46 am

I translated this macro to English and fixed the display bug when I worked on my Call of Cthulhu framework.

Here is my version. It's working pretty good:

Code: Select all

[h:jsonarray=Macro.args]
[h:jsonarraylength=json.length(jsonarray)]
[h:jsonobject=json.get(jsonarray,0)]
[h:jsonobjectfields = json.fields(jsonobject)]
[h:jsonobjectattrib = json.get(jsonobject,"Name")]
[h:jsonobjectlength=json.length(jsonobject)]

[h:numberOfRows = jsonarraylength]
[h:numberOfColumns = jsonobjectlength]

[h: oddRow = '#FFFFFF']
[h: evenRow = '#EEEEAA']

<html>
<head>
<title>Table</title>
<link rel="stylesheet" type="text/css" href="generic_css@Lib:gm"></link>
</head>
<body>
<table border="0" CELLPADDING=5 Align=center width=100%>
	[r, for(j,0,NumberOfColumns,1,""):"<th Align=center>"+ listGet(jsonobjectfields,j)]</th>
	[h:bgColor = oddRow]
	[r, for(i,0,NumberOfRows,1,""),code:
		{

		[h:jsonobject=json.get(jsonarray,i)]
		[if ((i/10)==floor(i/10) && i!=0),CODE :
		{ 
		[r, for(j,0,NumberOfColumns,1,""):"<th Align=center>"+ listGet(jsonobjectfields,j)]</th></tr>
		};{}]
		<tr>
		[r, for(j, 0, NumberOfColumns, 1, ""), code:
			{
			<td align='center' bgcolor=[r:bgColor]><span color='black'><b>
			[h:jsonobjectattrib=listGet(jsonobjectfields,j)]
			[r: json.get(jsonobject,jsonobjectattrib)]	
			</td>
			}]
		</tr>
		[h:bgColor = if(bgColor == oddRow, evenRow, oddRow)]	
		}]	
</table>
 </body>
 </html>

I think the big change is that I put a "r, " in the "for" loop statements.

EDIT: aliasmask posted a different solution, however I still prefer adding "r" (suppresses the quotes marks) because it will fix the issue for anyone using the macro, not just you.

Post by **aliasmask** » Wed Dec 11, 2019 7:54 am

Can you show us what your data looks like using this line of code at the top.

Code: Select all

 [dialog("D"):{<pre>[R: json.indent(replace(macro.args,"<","&lt;"))]</pre>}]

I was going to give you an example of how to put all your output in to a variable.

RPTools.net

json tables problem

json tables problem

Re: json tables problem

Re: json tables problem

Re: json tables problem

Re: json tables problem

Re: json tables problem

Re: json tables problem

Re: json tables problem

Re: json tables problem

Re: json tables problem