Replacement JAR for b89 for UPNP testing (Apr 12)

[wolph42]

the zip is broken!!

[JamzTheMan]

the zip is broken!!

OK, that was odd, 7z could open it but not windows. Should be fixed now, give it a try.

[wolph42]

the zip is broken!!

OK, that was odd, 7z could open it but not windows. Should be fixed now, give it a try.

zip works. upnp doesnt.

Spoiler

2013-07-07 11:14:08,472 [client.MapTool:297] ERROR - While configuring UPnP (1)
net.sbbi.upnp.messages.UPNPResponseException: Detailed error code :402, Detailed error description :invalid argument
at net.sbbi.upnp.messages.ActionMessageResponseParser.startElement(ActionMessageResponseParser.java:111)
at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(Unknown Source)
at com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(Unknown Source)
at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(Unknown Source)
at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(Unknown Source)
at com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(Unknown Source)
at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source)
at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(Unknown Source)
at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(Unknown Source)
at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(Unknown Source)
at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(Unknown Source)
at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
at javax.xml.parsers.SAXParser.parse(Unknown Source)
at net.sbbi.upnp.messages.ActionMessage.service(ActionMessage.java:155)
at net.sbbi.upnp.impls.InternetGatewayDevice.addPortMapping(InternetGatewayDevice.java:382)
at net.rptools.maptool.util.UPnPUtil.openPort(UPnPUtil.java:71)
at net.rptools.maptool.client.AppActionsrun(AppActions.java:1890)
at net.rptools.maptool.client.AppActions$ClientActionrun(AppActions.java:2838)

gather debug works (again). Also I noticed that the version number is n3 which is the same number as last version ?!? Wrong zip?

For good measure tested the 'upnp' version as discussed in this thread as well, and it worked perfectly!

I also replaced the .jar for the one in the OP, but same error message.

send PM to Azh with full error report

[JamzTheMan]

Yea, still version n3, no code changes. Maybe I still have something missing, I'll take a look.

[Azhrei]

I think the current brokenness is my fault. I tried cleaning some stuff up and I think I broke it. Wolph sent me his error log and I'll back out the patch I applied and we can try again...

Edit: Yep, it was my fault. I've fixed it and committed the code. I also added support for port mapping all routers found that are connected to the MapTool machine. The user still can't pick one (there's no UI for it).

[wolph42]

tested Jamz' version p. It works again !!

[JamzTheMan]

Cool. Helped having Az's latest code. Hopefully it works for others as well.

[wolph42]

I think the current brokenness is my fault. I tried cleaning some stuff up and I think I broke it. Wolph sent me his error log and I'll back out the patch I applied and we can try again...

Edit: Yep, it was my fault. I've fixed it and committed the code. I also added support for port mapping all routers found that are connected to the MapTool machine. The user still can't pick one (there's no UI for it).

And that's an invite for others !!

[Azhrei]

And that's an invite for others !!

Yeah, that's possible. It was actually pretty simple -- it just needed a loop added around the basic code. But yeah, adding code always adds the potential for new bugs!

[wolph42]

And that's an invite for others !!

Yeah, that's possible. It was actually pretty simple -- it just needed a loop added around the basic code. But yeah, adding code always adds the potential for new bugs!

funny, I quoted the wrong post and didn't finish my sentence, by which it got an entirely different meaning. What it should have been:

Cool. Helped having Az's latest code. Hopefully it works for others as well.

And that's an invite for others to test the UPNP feature !!

[JamzTheMan]

Mobile posting and autocowreck eh? I've had a bad run at it as well lately lol

It's like drunk dialing...