[patch - MapTool] Key map NPE Fix

Notes on testing the latest builds of MapTool

Moderators: dorpond, trevor, Azhrei

Post Reply
Lee
Dragon
Posts: 958
Joined: Wed Oct 19, 2011 2:07 am

[patch - MapTool] Key map NPE Fix

Post by Lee »

Discussed here, this fixes the unexpected input map behavior experienced under Java 7. Apparently, clearing the menu bar of it's mapping scheme results on bad calls downstream when a user hits a key on the keyboard.

I suspect that Java 7 handles the instantiating of Swing components differently, prioritizing the menu bar creation, wherein the map wipe that happens further down the launch process corrupts its input scheme. This is all conjecture, of course. While I could dig deeper into this, this patch seems to fix things, so I think I could be of more help elsewhere :)

Edit: put in a more accurate link of the reported bug
Attachments
[patch - MapTool] Input map NPE fix.txt
(770 Bytes) Downloaded 396 times
Last edited by Lee on Thu Sep 05, 2013 7:30 pm, edited 1 time in total.

User avatar
JamzTheMan
Great Wyrm
Posts: 1872
Joined: Mon May 10, 2010 12:59 pm
Location: Chicagoland
Contact:

Re: [patch - MapTool] Key map NPE Fix

Post by JamzTheMan »

Thanks Lee! I applied the patch and it fixed the issue in my campaigns.
-Jamz
____________________
Custom MapTool 1.4.x.x Fork: maptool.nerps.net
Custom TokenTool 2.0 Fork: tokentool.nerps.net
More information here: MapTool Nerps! Fork

User avatar
Azhrei
Site Admin
Posts: 12086
Joined: Mon Jun 12, 2006 1:20 pm
Location: Tampa, FL

Re: [patch - MapTool] Key map NPE Fix

Post by Azhrei »

Heh, commenting out one line fixes it. I love the simple ones (once they've been found, that is!).

Good work, Lee! And thanks for tracking this down! (SVN rev 5943)

Post Reply

Return to “Testing”