Token rendering
Moderators: dorpond, trevor, Azhrei
-
- Kobold
- Posts: 5
- Joined: Wed Apr 22, 2009 5:23 am
Token rendering
I noticed that some tokens looked kind of poor when MapTool scales them down, so... I took it upon myself to patch that a bit. It was a good exercise even if it isn't implemented, of course, but it would be neat to see it included.
Is there someone I can submit the diff to? It's against revision 5029.
Is there someone I can submit the diff to? It's against revision 5029.
Re: Token rendering
See the Sticky threads in the MapTool forum for descriptions of how to contribute.
Be aware that the graphics stuff is very much the purview of the main developer, Trevor, and patches in that area are likely to be rejected unless they meet his coding guidelines as well as his plans for the future in that area. (The sticky posts discuss some of that.)
Be aware that the graphics stuff is very much the purview of the main developer, Trevor, and patches in that area are likely to be rejected unless they meet his coding guidelines as well as his plans for the future in that area. (The sticky posts discuss some of that.)
- Full Bleed
- Demigod
- Posts: 4736
- Joined: Sun Feb 25, 2007 11:53 am
- Location: FL
Re: Token rendering
If it's not too processor intensive, better rendering at certain scales would be nice.
Maptool is the Millennium Falcon of VTT's -- "She may not look like much, but she's got it where it counts."
-
- Kobold
- Posts: 5
- Joined: Wed Apr 22, 2009 5:23 am
Re: Token rendering
Anyone who's interested in what I've done can check the diff out here: http://www.megaupload.com/?d=LAWRC3H8
- hyperactiveChipmunk
- Cave Troll
- Posts: 99
- Joined: Wed Apr 15, 2009 8:19 pm
Re: Token rendering
><StelardActek wrote:Anyone who's interested in what I've done can check the diff out here: http://www.megaupload.com/?d=LAWRC3H8
pastey.net is your friend
-hC
- Brigand
- Read-only User
- Posts: 1623
- Joined: Thu Feb 14, 2008 8:57 am
- Location: Nosy GM's can go frak themselves!
Re: Token rendering
I always zoom out at levels divisible by 25% because of the jagginess that happens when zooming in or out. Anything to help that would be grand.
-
- Kobold
- Posts: 5
- Joined: Wed Apr 22, 2009 5:23 am
Re: Token rendering
Or here, sure: http://pastey.net/114139
Keep in mind, I stopped working on this when it occurred to me it'd be pointless to continue if there was no chance of it being accepted.
Keep in mind, I stopped working on this when it occurred to me it'd be pointless to continue if there was no chance of it being accepted.
Re: Token rendering
If I were you I would PM trevor and talk to him about it. It's not like he's going to ignore you completely. It's a good idea, and if you can lighten his work load by producing code that meets his standards, I'm sure he'll be happy. The reasons it wouldn't be accepted, from what I understand, are more concerned with quality control than anything else. I'd say it's worth chatting him with if you think its an interesting problem.StelardActek wrote:Or here, sure: http://pastey.net/114139
Keep in mind, I stopped working on this when it occurred to me it'd be pointless to continue if there was no chance of it being accepted.
0+0=1, for very unstable CPUs.
- hyperactiveChipmunk
- Cave Troll
- Posts: 99
- Joined: Wed Apr 15, 2009 8:19 pm
Re: Token rendering
Looks like good stuff; I don't see any difficulties getting something like that included.
-hC
-hC
- trevor
- Codeum Arcanum (RPTools Founder)
- Posts: 11311
- Joined: Mon Jan 09, 2006 4:16 pm
- Location: Austin, Tx
- Contact:
Re: Token rendering
Sorry for the delay, been hectic around here.
I have reviewed the patch, but have some concerns about performance, I'll be getting with the author to bounce some ideas.
I have reviewed the patch, but have some concerns about performance, I'll be getting with the author to bounce some ideas.
Dreaming of a 1.3 release
- Full Bleed
- Demigod
- Posts: 4736
- Joined: Sun Feb 25, 2007 11:53 am
- Location: FL
Re: Token rendering
I figured that performance would be something of a trade-off to get better dithering.trevor wrote:Sorry for the delay, been hectic around here.
I have reviewed the patch, but have some concerns about performance, I'll be getting with the author to bounce some ideas.
Any chance there could be a toggle for "High Performance Zoom" or "High Quality Zoom"?
Maptool is the Millennium Falcon of VTT's -- "She may not look like much, but she's got it where it counts."
- Brigand
- Read-only User
- Posts: 1623
- Joined: Thu Feb 14, 2008 8:57 am
- Location: Nosy GM's can go frak themselves!
Re: Token rendering
I'd like it if I could set the amount that MapTool zooms in and out with a mousewheel click. I'd like to be able to bounce around between zoom levels divisible by 25%.
- trevor
- Codeum Arcanum (RPTools Founder)
- Posts: 11311
- Joined: Mon Jan 09, 2006 4:16 pm
- Location: Austin, Tx
- Contact:
Re: Token rendering
Feel free to post this into the Feature Request forumBrigand wrote:I'd like it if I could set the amount that MapTool zooms in and out with a mousewheel click. I'd like to be able to bounce around between zoom levels divisible by 25%.
Dreaming of a 1.3 release
- trevor
- Codeum Arcanum (RPTools Founder)
- Posts: 11311
- Joined: Mon Jan 09, 2006 4:16 pm
- Location: Austin, Tx
- Contact:
Re: Token rendering
What would be great is if we could get bothFull Bleed wrote: Any chance there could be a toggle for "High Performance Zoom" or "High Quality Zoom"?
Dreaming of a 1.3 release
-
- Kobold
- Posts: 5
- Joined: Wed Apr 22, 2009 5:23 am
Re: Token rendering
I did take performance into account when putting this patch together. Depending on how much the image will be resized in the drawing, it does different things to perform the blur. It seems to run fine on my machine with numerous tokens on screen. That said, obviously it's going to be slower than not blurring before resizing.
I would have tried making the different token rendering technique an option, but I don't know how to do user interfaces in Java. I'd be happy to learn, if there's a chance of this being included.
I would have tried making the different token rendering technique an option, but I don't know how to do user interfaces in Java. I'd be happy to learn, if there's a chance of this being included.